Skip to content

Remove Python type annotation hint ambiguity from the test case of KeyedOptimizer #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangkuiyi wants to merge 1 commit into from
Closed

Remove Python type annotation hint ambiguity from the test case of KeyedOptimizer #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 29 additions & 27 deletions torchrec/optim/tests/test_keyed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import os
import unittest
from typing import Dict, Any
from typing import Dict, Any, List

import torch
import torch.distributed as dist
Expand Down Expand Up @@ -74,34 +74,36 @@ def test_load_state_dict(self) -> None:
)

# Assert state_dict is as expected.
expected_state_dict = {
"state": {
"param_1": {
"one": 1.0,
"tensor": torch.tensor([5.0, 6.0]),
"sharded_tensor": dist._sharded_tensor.full(
# pyre-ignore [28]
dist._sharded_tensor.ChunkShardingSpec(
dim=0, placements=["rank:0/cpu"]
),
(4,),
fill_value=1.0,
state: Dict[str, Any] = {
"param_1": {
"one": 1.0,
"tensor": torch.tensor([5.0, 6.0]),
"sharded_tensor": dist._sharded_tensor.full(
# pyre-ignore [28]
dist._sharded_tensor.ChunkShardingSpec(
dim=0, placements=["rank:0/cpu"]
),
},
"param_2": {"two": 2.0},
(4,),
fill_value=1.0,
),
},
"param_groups": [
{
"params": ["param_1"],
"param_group_val_0": 3.0,
"param_group_val_1": 4.0,
},
{
"params": ["param_2"],
"param_group_val_0": 5.0,
"param_group_val_1": 6.0,
},
],
"param_2": {"two": 2.0},
}
param_groups: List[Dict[str, Any]] = [
{
"params": ["param_1"],
"param_group_val_0": 3.0,
"param_group_val_1": 4.0,
},
{
"params": ["param_2"],
"param_group_val_0": 5.0,
"param_group_val_1": 6.0,
},
]
expected_state_dict = {
"state": state,
"param_groups": param_groups,
}
self._assert_state_dict_equals(
expected_state_dict, keyed_optimizer.state_dict()
Expand Down