Adding fbgemm repository as a git submodule to TorchRec #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@animan42 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
YazhiGao
pushed a commit
to YazhiGao/torchrec-2
that referenced
this pull request
Feb 24, 2022
Summary: Pull Request resolved: meta-pytorch/torchrec#88 Pull Request resolved: pytorch/FBGEMM#940 Pull Request resolved: meta-pytorch/torchrec#21 rename permute_sparse_data to permute_2D_sparse_data as it requires 'lengths' is a 2D tensor. Will add permute_1D_sparse_data in the follow-up diff. Reviewed By: jianyuh Differential Revision: D34333459 fbshipit-source-id: b00936249c66764a2ee5757487d6034cc287bf6f
jasonjk-park
pushed a commit
to jasonjk-park/FBGEMM
that referenced
this pull request
Feb 26, 2022
…ytorch#88) Summary: Pull Request resolved: meta-pytorch/torchrec#88 Pull Request resolved: pytorch#940 Pull Request resolved: meta-pytorch/torchrec#21 rename permute_sparse_data to permute_2D_sparse_data as it requires 'lengths' is a 2D tensor. Will add permute_1D_sparse_data in the follow-up diff. Reviewed By: jianyuh Differential Revision: D34333459 fbshipit-source-id: b00936249c66764a2ee5757487d6034cc287bf6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TorchRec OSS installation currently requires 3 steps:
We can simplify this to a single step by bringing in fbgemm_gpu into TorchRec directory