Update torchrec's submodule fbgemm commit id #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: **context** fbgemm was failing to install out of torchrec's setup.py command because the THC.h header file was being included in the fbgemm repo but it was removed: https://www.internalfb.com/intern/qa/291103/thcthch-not-found----fblearner-flow-compilations-b This was fixed here: D32872476 but was not reflected in torchrec's checkout of fbgemm as that has to be manually updated. **this diff:** This updates the commit id to be the latest. I'll take a look at how to automate this process if possible. The installation process can break if our version of fbgemm gets too stale. Reviewed By: jianyuh Differential Revision: D33251641 fbshipit-source-id: 34ad7d0176e843889354d050a3923d99a4a261e7
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D33251641 |
Contributor
Author
|
merged with shipit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
fbgemm was failing to install out of torchrec's setup.py command because the THC.h header file was being included in the fbgemm repo but it was removed.
This was fixed here: D32872476 but was not reflected in torchrec's checkout of fbgemm as that has to be manually updated.
this diff:
This updates the commit id to be the latest.
I'll take a look at how to automate this process if possible. The installation process can break if our version of fbgemm gets too stale.
Reviewed By: jianyuh
Differential Revision: D33251641