create ModelSelectionConfig and fix bugs #3467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84755189. |
meta-cla
bot
added
the
CLA Signed
TroyGarden
force-pushed
the
export-D84755189
branch
from
e3c28b1 to
3e21822
Compare
Summary: # context * move `ModelSelectionConfig` to test_utils.py and make `create_model_config` a class method * fix previously failed test and some pyre ignore issues * bump pre-commit check version from python 3.9 to python 3.12 Differential Revision: D84755189
TroyGarden
force-pushed
the
export-D84755189
branch
from
3e21822 to
004146e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
ModelSelectionConfigto test_utils.py and makecreate_model_configa class methodDifferential Revision: D84755189