rename fbgemm.permute_sparse_data to fbgemm.permute_2D_sparse_data #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: rename permute_sparse_data to permute_2D_sparse_data as it requires 'lengths' is a 2D tensor. Will add permute_1D_sparse_data in the follow-up diff. Reviewed By: YazhiGao Differential Revision: D34333459 fbshipit-source-id: 56490071623d8bfa2992a1fafd6fedf9dba20d72
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D34333459 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 20, 2022
Summary: Pull Request resolved: #88 Pull Request resolved: pytorch/FBGEMM#940 Pull Request resolved: #21 rename permute_sparse_data to permute_2D_sparse_data as it requires 'lengths' is a 2D tensor. Will add permute_1D_sparse_data in the follow-up diff. Reviewed By: jianyuh Differential Revision: D34333459 fbshipit-source-id: b00936249c66764a2ee5757487d6034cc287bf6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: rename permute_sparse_data to permute_2D_sparse_data as it requires 'lengths' is a 2D tensor. Will add permute_1D_sparse_data in the follow-up diff.
Reviewed By: YazhiGao
Differential Revision: D34333459