(torchx/schedulers) Restore Scheduler iface generic types #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87901987. |
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
Summary: The `torchx.schedulers.Scheduler` interface was made overly generic to overload the concept of an "orchestration" scheduler in #1022. DAG orchestration has never been something torchx should've supported natively. Instead torchx AppDefs can be adapted to an orchestrator framework's notion of a "NodeDefinition". This way users can use job definitions defined using torchx's AppDef as a node in a DAG to string together applications in a specific execution order. This PR/Diff reverts the over-genericized `torchx.schedulers.Scheduler` back to supporting `AppDef` and `AppDryRunInfo` as the primitives. Differential Revision: D87901987
facebook-github-bot
force-pushed
the
export-D87901987
branch
from
aef677e to
509b850
Compare
Summary: The `torchx.schedulers.Scheduler` interface was made overly generic to overload the concept of an "orchestration" scheduler in #1022. DAG orchestration has never been something torchx should've supported natively. Instead torchx AppDefs can be adapted to an orchestrator framework's notion of a "NodeDefinition". This way users can use job definitions defined using torchx's AppDef as a node in a DAG to string together applications in a specific execution order. This PR/Diff reverts the over-genericized `torchx.schedulers.Scheduler` back to supporting `AppDef` and `AppDryRunInfo` as the primitives. Reviewed By: AbishekS Differential Revision: D87901987
facebook-github-bot
force-pushed
the
export-D87901987
branch
from
509b850 to
2cee4b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
torchx.schedulers.Schedulerinterface was made overly generic to overload the concept of an "orchestration" scheduler in #1022.DAG orchestration has never been something torchx should've supported natively. Instead torchx AppDefs can be adapted to an orchestrator framework's notion of a "NodeDefinition". This way users can use job definitions defined using torchx's AppDef as a node in a DAG to string together applications in a specific execution order.
This PR/Diff reverts the over-genericized
torchx.schedulers.Schedulerback to supportingAppDefandAppDryRunInfoas the primitives.Differential Revision: D87901987