New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Nested Dictionary Fields in the Query builder #1328

Closed
Addvilz opened this Issue Oct 22, 2015 · 9 comments

Comments

Projects
None yet
7 participants
@Addvilz
Contributor

Addvilz commented Oct 22, 2015

Any chance we could query against nested fields in Mongo? Example document:

{
    "id": 1234,
    "properties": {
        "key": "val",
        "otherkey": 123
    },
    "value": 33,
    "amount": 12
}

In this case we should really use ability to access properties.* as any other field.

@salsakran salsakran added the Bug label Oct 27, 2015

@camsaul camsaul changed the title from Unable to query nested fields to Expose Mongo Dictionary Fields in the Query builder Nov 13, 2015

@agilliland agilliland removed the Bug label Jan 22, 2016

@camsaul camsaul self-assigned this Feb 26, 2016

@camsaul camsaul removed their assignment Mar 23, 2016

@salsakran salsakran added this to the 0.19.0 milestone Jun 17, 2016

@salsakran

This comment has been minimized.

Show comment
Hide comment
@salsakran

salsakran Jun 17, 2016

Contributor

We've been sitting on this for ages. What needs to happen for this to work on the front end?

Contributor

salsakran commented Jun 17, 2016

We've been sitting on this for ages. What needs to happen for this to work on the front end?

@salsakran salsakran changed the title from Expose Mongo Dictionary Fields in the Query builder to Expose Nested Dictionary Fields in the Query builder Jun 17, 2016

@salsakran salsakran removed this from the 0.19.0 milestone Jun 17, 2016

@aelanic

This comment has been minimized.

Show comment
Hide comment
@aelanic

aelanic Jun 22, 2016

Raised the same issue in #2807 . Any idea when is this getting fixed?

aelanic commented Jun 22, 2016

Raised the same issue in #2807 . Any idea when is this getting fixed?

@camsaul

This comment has been minimized.

Show comment
Hide comment
@camsaul

camsaul Oct 15, 2016

Member

It sounds like this may be fixed already, since we have #3173 open to fix behaviors with this. @salsakran do you know if that's the case?

Member

camsaul commented Oct 15, 2016

It sounds like this may be fixed already, since we have #3173 open to fix behaviors with this. @salsakran do you know if that's the case?

@salsakran

This comment has been minimized.

Show comment
Hide comment
@salsakran

salsakran Oct 15, 2016

Contributor

not sure. Let me poke around our mongo dataset.

Contributor

salsakran commented Oct 15, 2016

not sure. Let me poke around our mongo dataset.

@gierschv

This comment has been minimized.

Show comment
Hide comment
@gierschv

gierschv Oct 28, 2016

Hey there,

No, it's not fixed, I have the nested fields represented as JSON in tables:

screenshot 2016-10-28 22 23 30

They are displayed in a single level (without the parent fields) in the filtered by selector, and in the visualization settings only the root fields are listed.

Vincent

gierschv commented Oct 28, 2016

Hey there,

No, it's not fixed, I have the nested fields represented as JSON in tables:

screenshot 2016-10-28 22 23 30

They are displayed in a single level (without the parent fields) in the filtered by selector, and in the visualization settings only the root fields are listed.

Vincent

@camsaul

This comment has been minimized.

Show comment
Hide comment
@camsaul

camsaul Oct 28, 2016

Member

@gierschv this issue isn't taking about how nested fields are displayed but rather if you can see them as options in things like the filter menu. e.g. if you're able to do something like filter by statistics.sessions == 2

Member

camsaul commented Oct 28, 2016

@gierschv this issue isn't taking about how nested fields are displayed but rather if you can see them as options in things like the filter menu. e.g. if you're able to do something like filter by statistics.sessions == 2

@Addvilz

This comment has been minimized.

Show comment
Hide comment
@Addvilz

Addvilz Oct 29, 2016

Contributor

Afaik sub document keys are currently merged together with parent keys. Not okay imho.

Contributor

Addvilz commented Oct 29, 2016

Afaik sub document keys are currently merged together with parent keys. Not okay imho.

@tlrobinson

This comment has been minimized.

Show comment
Hide comment
@tlrobinson

tlrobinson Nov 14, 2016

Member

To be clear, you can currently filter, group, aggregate, and sort nested fields, the one remaining piece is returning the nested fields as individual columns in "raw data" queries.

@camsaul is there a reason we're not doing that by default?

FYI manually adding the nested fields using the "additional fields" branch does work (but that branch is a prototype) #3043

Member

tlrobinson commented Nov 14, 2016

To be clear, you can currently filter, group, aggregate, and sort nested fields, the one remaining piece is returning the nested fields as individual columns in "raw data" queries.

@camsaul is there a reason we're not doing that by default?

FYI manually adding the nested fields using the "additional fields" branch does work (but that branch is a prototype) #3043

@camsaul

This comment has been minimized.

Show comment
Hide comment
@camsaul

camsaul Jan 9, 2017

Member

I think the core issues here have been addressed by #3738.

As far as automatically flattening all nested keys for bare rows query, that's something we could potentially do, but it's more of a new feature with a different scope than this issue. I've opened #4098 for that idea so we can close this one out.

Member

camsaul commented Jan 9, 2017

I think the core issues here have been addressed by #3738.

As far as automatically flattening all nested keys for bare rows query, that's something we could potentially do, but it's more of a new feature with a different scope than this issue. I've opened #4098 for that idea so we can close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment