Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Unify API endpoints for executing actions/emitters [nice to have] #23275

Closed
Tracked by #22542
camsaul opened this issue Jun 9, 2022 · 2 comments
Closed
Tracked by #22542

Comments

@camsaul
Copy link
Member

camsaul commented Jun 9, 2022

Part of #22542

Right now we have three custom action execution endpoints

  • The "Row action" endpoint for executing DELETE/UPDATE
  • The "Table action" endpoint for executing INSERT
  • The custom emitter endpoint for executing custom emitters (currently only QueryActions are supported)

We should think about whether we can unify these so there's only one endpoint for executing any sort of Action/Emitter and if they can all share a common parameters format. Not sure what this should look like so let's brainstorm a bit. If it turns out to be ugly we don't have to do this -- this is more of a nice to have than a requirement.

@camsaul camsaul changed the title [Actions] Unify API endpoints for actions (maybe) [Actions] Unify API endpoints for executing actions/emitters Jun 9, 2022
@camsaul camsaul changed the title [Actions] Unify API endpoints for executing actions/emitters [Actions] Unify API endpoints for executing actions/emitters (nice to have) Jun 9, 2022
@camsaul camsaul changed the title [Actions] Unify API endpoints for executing actions/emitters (nice to have) [Actions] Unify API endpoints for executing actions/emitters [nice to have] Jun 9, 2022
@camsaul camsaul mentioned this issue Jun 9, 2022
63 tasks
@camsaul
Copy link
Member Author

camsaul commented Jul 19, 2022

The "row action" and "table action" endpoints were unified as part of #23922, and the new bulk stuff is using that lone endpoint as well.

But emitters are executed via a different pathway still.

@snoe
Copy link
Contributor

snoe commented Oct 24, 2022

All execution is now done through the dashboard/dashcard/execute endpoint

@snoe snoe closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants