Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: More customizability in pulse/alert timings, conditional pulses #3846

Open
aagarwal-gtr opened this issue Dec 1, 2016 · 20 comments

Comments

@aagarwal-gtr
Copy link

commented Dec 1, 2016

Currently, I can only set the email in a pulse to go out daily / weekly / monthly. I would like to be able to set this even hourly or n-minutes-ly so maybe a tab to set the regular time interval to allow for infinite choices instead of the current three. Also I can only choose between 12AM - 11AM GMT which translates to 530AM - 630PM for us, this is a limitation. I don't see the reason behind having the time as a set value, I should be allowed to enter whatever time i want. same goes for the slack integration.

secondary request: any plans for stuff like allowing adding branding / custom quotes to a pulse email?

Also, would be neat if i can have conditional pulses meaning if a questions output exceeds some filter then the pulse gets sent out enabling monitoring for us. This is just a thought so let me know if this seems feasible.

@camsaul

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

@aagarwal-gtr, you want to send a pulse every minute? 😳 Can you help us understand a little more about your use case?

@aagarwal-gtr

This comment has been minimized.

Copy link
Author

commented Dec 13, 2016

@camsaul no 😑
had a look at the pulses again and stupid me didnt realise you could change the AM to PM in the little dropdown. sorry

anyways my primary gripe is that i can only choose time as hour times (eg 4am which translates to 930am in my timezone) I cannot schedule a pulse to go out at 9am (in my timezone) every morning. why not have a textbox there so that i can enter whatever time i like (even 915am = 345am gmt), after calculating it according to my timezone?

also, i can only schedule daily, weekly or monthly. i cannot schedule something to go out every 8hours. again, why not have a textbox here where i can enter whatever regular time period i would like to have (in hours maybe)?
i hope this makes sense

@camsaul camsaul added the Type:UX label Dec 13, 2016

@camsaul

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

Thanks @aagarwal-gtr that makes sense. @metabase/core-developers what do you guys think?

@timc13

This comment has been minimized.

Copy link

commented Jan 19, 2017

+1 for conditional pulses

My use case is a single count number...and I only want to pulse if the count is above a threshold (greater than 0)

@tlrobinson

This comment has been minimized.

Copy link
Member

commented Jan 20, 2017

Conditional pulses related to "Skip pulse if no results" #2430

@mazameli

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

I've played around with some ideas for more control over Pulse scheduling. This doesn't refer to conditional Pulses yet, though. Overall, I've just added some additional UI inputs, replaced dropdowns with input fields or radio selects where I could, and cleaned up some of the visual design.

If someone feels strongly about these additional controls, it would be great to get some frontend help from the community.

Daily settings
The main change here is an input box instead of a drop down for the hour to allow specific times to be typed in, like 3:17 AM or whatever.
daily

Daily, custom
The custom setting allows the choice of which days to send the Pulse, allowing things like M/W/F, or skipping Saturday and Sunday, or whatever days the weekends might be in your locale.
daily custom

Weekly
This is largely just a change to the UI elements, though it adds the ability to send every x number of weeks, instead of each and every week. It carries over the changes to the hour input as well.
weekly

Monthly
monthly

Hourly
Currently, the Hourly setting is only available for Slack pulses, though the only reason I suppose we wouldn't add this to emails is to keep things simpler. I've added some selections to limit the hours between which the pulse gets sent, and a setting to chose when during the hour to send it (addresses #3135).
slack hourly

What I haven't added

  • This doesn't address quarterly pulses (#3237), though that could be yet another radio option under the send section.
  • Doesn't address conditional pulse sending
@jornh

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2017

This issue sounds very much like it could now be resolved by the alerts feature in v0.27.0 @aagarwal-gtr

@mazameli mazameli changed the title Feature Request: More customizability in pulse timings, conditional pulses Feature Request: More customizability in pulse/alert timings, conditional pulses Mar 5, 2018

@darylteo

This comment has been minimized.

Copy link

commented Oct 23, 2018

@jornh sorry to resurrect an old thread but this currently would be a very helpful feature for us where I work, to get a regular monitor doing healthchecks on a per minute basis. The alerts feature you mention has the same time granulurity as the pulses feature.

The proposal by @mazameli is commendable, and looks extremely powerful. However, it seems like a lots of gold plating that has left this issue wallowing low on the priority list.

If the maintainers would accept a PR where we simply add the absolute bare bones option of per minute polling for pulses and alerts, leaving Hourly as the default , I am willing to have a lookthrough on my own time (outside business hours) to get this done.

Let me know your thoughts, thanks.
Daryl
Tech Lead - Listcorp

@ans-4175

This comment has been minimized.

Copy link

commented Nov 13, 2018

Guys, any news on this?
Care to share what files need to check if I want to look it up?

@ghost

This comment has been minimized.

Copy link

commented Nov 28, 2018

Any roadmap for minute level alerts. Metabase looks great but atleast 5 min level alerting is a deal breaker for us to use Metabase. Explored other solutions like Redash which supports minute level alerting. Don't want to use Redash for now and migrate to Metabase later. So any update here would be good.

We would love to contribute if someone can guide us on where to make changes

@nileshtrivedi

This comment has been minimized.

Copy link

commented Dec 12, 2018

It might be more empowering to implement standards for recurring events like RRULE (RFC 5545) or crontab syntax. Metabase already allows users to use raw SQL for more control. I think allowing such powerful constructs for the scheduling continues the same glorious tradition of "make simple things easy and hard things possible" which I love Metabase for.

@BrianMehrman

This comment has been minimized.

Copy link

commented Dec 13, 2018

I would love to help out to help get the ability to set emails for pulses down to the minute. We are currently running into an issue with the hourly database sync and analysis affecting our queries run for our pulses that can only be set to run on the hour.

@blhf

This comment has been minimized.

Copy link

commented Jan 2, 2019

An option like 'Every' Minute, Hour, Day (Specified Time), etc. would be nice addition on the GUI for the alerts as this would limit multiple creation of alerts for a single pulse. Hope we can add this in the road map to improve pulse function.

@kreno

This comment has been minimized.

Copy link

commented Jan 16, 2019

I would like to add a request for bi-weekly. We do payroll every other week, and I'd like the alert to run after the payroll is done. Now I have to set it to run weekly, and tell the user to ignore the data on the odd week.

Thanks!

@nileshtrivedi

This comment has been minimized.

Copy link

commented Jan 22, 2019

@mazameli @camsaul @tlrobinson If you make a decision on this and recommend a plan, we will be glad to implement this. Hoping to hear from you soon.

@nileshtrivedi

This comment has been minimized.

Copy link

commented Feb 5, 2019

@camsaul @mazameli Any decision on this? See my comment above.

@kdoh

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Hey all,

So I did a bit of investigation with the help of the team and one thing that's blocking more pulse customization is the simple fact that under the hood, the way we store pulse scheduling info is fairly tied to our current set of options (daily, weekly, monthly, and fixed set of hour options).

In order for us to enable the set of further options we do want to allow, this first needs to change to make sure the scheduling system stays sane. We would gladly accept some help on this given all the balls we have in the air right now, but I'll be up front and say it's not a light bit of work and anyone thinking of contributing should check in with @camsaul first for more info on the problem and the solution. Creating an issue to this effect would be a good place for that discussion and also let us know you have interest in working on that problem.

Once that's done, I think we can start to break this down into smaller bits as @darylteo suggested and look at simple updates that extend pulse scheduling functionality but that don't devolve into a hodgepodge of custom picker UIs and every third Wednesday style options that prevent us from adding some reasonable customization. @mazameli and I looked over the old proposal up above and both agreed it's not necessarily the direction we want to pursue so we don't suggest using it as a guidepost for what scheduling we will support or that you should try to build. We still want to keep these rather light and digestible both in content and in options since we don't intend for pulses to be used as a full reporting solution (that may or may not end up being its own thing down the line).

Once we have the backend support, an example of the kind of thing we would accept on the UI side contribution wise would be replacing our <Hour> dropdown with a set of inputs for the hour and minute. That would enable more custom timing while actually improving the speed and ease of picking times so it'd be both a UX and functionality win.

For things at the hour and minute level I do think it might make sense to look more at the underlying use cases and needs behind the desire for those intervals before we go adding in those options. I'd suspect that what people might need there is not a way to send pulses every 5 minutes but more functionality in our alerts feature.

@tlrobinson

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

BTW we have a HoursMinutesInput component in the QB filter pickers we might be able to extract and reuse.

@nileshtrivedi

This comment has been minimized.

Copy link

commented Feb 18, 2019

@kdoh Thanks. I created #9436 for the discussion on making pulse scheduling info more flexible as you requested in the second paragraph.

@Huseyn-Ahmadli

This comment has been minimized.

Copy link

commented Jul 28, 2019

I want to set up alert on query.
when new result will occur metabase immediately send me email message. now it just possible on every hour, day, week. It will be better to get alerts on time.

and For example now query has no result but when it appers then just send email alert. it will make our work too easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.