Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should move Authentication on/off toggles out of their config forms #5555

Closed
mazameli opened this issue Jul 24, 2017 · 3 comments
Closed
Assignees
Labels
Administration/Auth Google Auth, LDAP, pw+email login Type:UX
Milestone

Comments

@mazameli
Copy link
Contributor

This doesn't need to happen for 0.25, but one way we could improve the UX for the Google Sign-in and LDAP auth settings is:

  1. move the enabled/disabled toggle for LDAP from the configuration form to the summary card:

I.e., from here:
screen shot 2017-07-24 at 10 41 58 am

to here:
screen shot 2017-07-24 at 10 42 09 am

Reason being, right now it's a bit confusing that you can fill in all the settings and hit save, and if you forgot to hit the toggle you might think LDAP is enabled. You might also have filled in the settings, then scroll back to the top and flip the toggle, not realizing you needed to hit Save Changes, then navigate away and unknowingly lose your changes. Separating the toggle out lets the form just be "here are my settings," and then the toggle becomes about whether or not those settings should take effect.

  1. The Google Sign-in form currently doesn't have an on/off switch, so we could add one and put it on the Google Sign-in summary card to make the two forms behave the same.
@lindsay-stevens
Copy link
Contributor

@mazameli is this ticket still valid? I think the proposal is how the UI looks now (v0.34+).

@mazameli
Copy link
Contributor Author

mazameli commented Feb 6, 2020

Yeah, it's still valid. The screenshots show how the current UI looks, but the proposal I wrote out in the description is to move the on/off toggles on to the cards depicted in the second screenshot, e.g. somewhere next to the "Configure" button.

@ranquild
Copy link
Contributor

Fixed by #19428

@flamber flamber added this to the 0.45 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Auth Google Auth, LDAP, pw+email login Type:UX
Projects
None yet
Development

No branches or pull requests

4 participants