Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mapping doesn't work for PostgreSQL views #6065

Open
lfcipriani opened this Issue Sep 28, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@lfcipriani
Copy link

lfcipriani commented Sep 28, 2017

  • Metabase version: 0.25.2
  • Metabase hosting environment: ubuntu, Mac app
  • Metabase internal database: Postgresql

Steps to reproduce:

  • Create a Postgresql view from a table that has a numeric field;
  • Go to original table data model and make sure you can create a custom mapping for that field;
  • Then go to the View and try to add custom mapping for the same field;
  • The option "Custom mapping" never appears for Views, but in Tables they appear.
@salsakran

This comment has been minimized.

Copy link
Contributor

salsakran commented Sep 29, 2017

Can you screenshot the datamodel "raw" view for that view and ideally the underlying table as well, if you can.

@lfcipriani

This comment has been minimized.

Copy link
Author

lfcipriani commented Sep 29, 2017

Here's table raw datamodel (I want to custom map category field):

screenshot from 2017-09-29 22-28-08

Here's view raw datamodel (should be the same view but scoped for a user):

screenshot from 2017-09-29 22-29-00

@shiena

This comment has been minimized.

Copy link

shiena commented Mar 29, 2018

I also have the same issue with redshift.
However, I found that Custom mapping does not work if it contains null in the fetched value.
And I found a type checked here.

https://github.com/metabase/metabase/blob/v0.28.3/frontend/src/metabase/admin/datamodel/containers/FieldApp.jsx#L514-L524

@ddio

This comment has been minimized.

Copy link

ddio commented May 11, 2018

I found the root cause may related to whether metabase has write permission to the table.

Same issue can be observed when using read only account to access Postgres regular table.

By switching to account who has write permission, metabase allow me to create custom mapping again

@shedd

This comment has been minimized.

Copy link

shedd commented Jun 16, 2018

I am also running into this issue with a BigQuery datasource.

No matter what field type I select, there is no option to create Custom Mapping for the field.

screen shot 2018-06-16 at 9 25 37 am

To address the suspected causes suggested in the thread - my user does have write access to the data table, however, there are nulls in these columns.

Any known workarounds?

@FallenChromium

This comment has been minimized.

Copy link

FallenChromium commented Nov 3, 2018

@shedd I made a SELECT VALUES view and changed column type to FK, so the option "FK mapping" appeared. That's frustrating though, also probably related to #8116.
Also I think it should be wise to also allow custom remap to string types, because It looks like the check that @shiena pointed out is valid only for numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.