Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bar Charts in Pulses not rendering with user-defined X/Y axis #6895

Closed
senior opened this issue Feb 7, 2018 · 1 comment
Closed

Bar Charts in Pulses not rendering with user-defined X/Y axis #6895

senior opened this issue Feb 7, 2018 · 1 comment
Labels
Priority:P2 Average run of the mill bug Type:Bug Product defects
Milestone
0.28.1

Comments

@senior
Copy link
Contributor

senior commented Feb 7, 2018

Pulses with cards that have a row chart and user-defined X and Y axis don't render their graph correctly. It looks like I missed it here. I'm not sure if the bar chart code just needs to be updated to use the new column functions or if there's a problem with the X/Y axis code as well.
@senior senior added Type:Bug Product defects Priority:P2 Average run of the mill bug labels Feb 7, 2018
senior pushed a commit that referenced this issue Feb 7, 2018
@iethree
Fix the pulse bar chart rendering to use overriden columns
9f77dce 
The bar chart rendering code was still using the old first/second
column logic, this commit switches it to using the new x/y axis column
logic which will account for user specified graph columns.

Fixes #6895
@senior senior mentioned this issue Feb 7, 2018
Merged
@salsakran salsakran added this to the 0.28.1 milestone Feb 9, 2018
@salsakran
Copy link
Contributor

fixed via #6897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:P2 Average run of the mill bug Type:Bug Product defects
Projects
None yet
Milestone
0.28.1
Development

No branches or pull requests
2 participants
@salsakran @senior