Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields included in Pulses even if excluded from question #7918

Open
ehk20 opened this issue Jun 21, 2018 · 5 comments

Comments

@ehk20
Copy link

commented Jun 21, 2018

Not sure if this is a bug or a 'feature' but I find it counter-intuitive:

  1. Create a question with raw data output
  2. Customize the table to include a subset of fields
  3. Create a Pulse based on this question and it includes all fields rather than limiting the output to the fields selected in 2.

v0.29.3

@ehk20 ehk20 changed the title Fields included in Pulses that have been excluded Fields included in Pulses even if excluded from question Jun 22, 2018

@mazameli

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2018

Reproduced this on v0.29.3 on Docker. I would consider this a bug.

@joebordes

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

I have a related issue: if you reorder the columns in the question, the pulse does not respect that column order.

Do you prefer that I open another issue?

@senior

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2018

This has been fixed for new (or updated) questions via #8004. The issue that @joebordes mentioned is also fixed. I tested this out on current master, removing all of the columns in a result except for 3 and changing their order. Both the reduced set of columns and the new order show up in pulses. #8004 will be included in the 0.30.0 release which should be out soon.

@metabase/core-developers This fix will only apply to questions that the user has touched (created or updated) after upgrading to 0.30.0. Should we be migrating existing questions to the fields query clause used in #8004?

@tlrobinson

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

I think the conclusion of our in-person conversation was it isn't worth migrating old questions. If you want to manually migrate a question the easiest way is to open the question, open the visualization settings, make any change to the settings (e.x. add or remove a column), click "Done" (then optionally undo that setting change) and save the question.

@jornh

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2018

According to #7918 (comment) above this can be closed as fixed in 0.30.0

Related Discourse topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.