New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code autocomplete: automatically add space after keywords #8710

Open
fulldecent opened this Issue Oct 17, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@fulldecent
Contributor

fulldecent commented Oct 17, 2018

Test case

  1. Ask a question
  2. SQL
  3. Type sel
  4. Expect autocomplete select keyword is an option
  5. Press TAB

Expected outcome

The text select is active in your text editor, including the space after the word select.

Actual outcome

The text select is active in your text editor. You will very likely type SPACE after each time you use this feature.

Discussion

It is possible that the user intends to add a ( after the select, rather than a space, but this is extremely rare.

It is also possible that the user intends to start a new line after autocomplete. Luckily, that situation is easy to correct for:

  • If the current line matches /\s$/ and the user presses RETURN then perform s/\s$// before going to the new line.

It is painful to introduce autocorrects that are not what the use intends, perhaps the threshold should be 95% of people want something before an autocorrect is implement. This issue definitely falls into that category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment