Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw question filter handles do not work #9357

Open
fetanchaud opened this Issue Jan 31, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@fetanchaud
Copy link

commented Jan 31, 2019

Hi all,

In the latest version,

Raw question filters have handles, but they do not work:
you can move the filter, but when dropped, it comes back to its first place.

Is it intended behaviour ?

Best regards,

@flamber

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

Hmmm.... I was searching for an existing bug on this, because I knew I had seen it before, but it turns out that it was only reported in the forum:
https://discourse.metabase.com/t/variable-fields-reorganising-after-save-native-query/4716

You'll see an error in the console, when you drag and drop the filter/parameter:

Uncaught TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at app-main.bundle.js?78262faa1c529a733077:5
    at n.updateIn (vendor.bundle.js?78262faa1c529a733077:12)
    at t.value (app-main.bundle.js?78262faa1c529a733077:5)
    at n.setParameterIndex (app-main.bundle.js?78262faa1c529a733077:5)
    at r.handleSortEnd (app-main.bundle.js?78262faa1c529a733077:5)
    at e.handleSortEnd (vendor.bundle.js?78262faa1c529a733077:189)

EDIT: Reordering was added in #8462, but I'm not sure if it worked in 0.30 since I skipped that version.
EDIT 2: Just adding a reference to #5136, since that issue and this issue makes native query parameters hard to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.