Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql error not reported anymore #9942

Closed
thomasLeclaire opened this issue May 10, 2019 · 2 comments
Closed

postgresql error not reported anymore #9942

thomasLeclaire opened this issue May 10, 2019 · 2 comments
Assignees
Labels
Database/Postgres Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Milestone

Comments

@thomasLeclaire
Copy link

  • Your databases: (e.x. MySQL, Postgres, MongoDB, …) : PG9.6 and PG11

  • Metabase version: (e.x. 0.19.3) 32.6 and 32.7. (everything ok in 32.5 and before)

  • Metabase hosting environment: (e.x. Mac app, Elastic Beanstalk, Docker, Heroku, Linux/Ubuntu 12) : docker

  • Metabase internal database: (e.x. H2 (default), MySQL, Postgres) : PG9.6

  • Repeatable steps to reproduce the issue
    When i create some custom SQL request with explicit error or syntax error, I don't have anymore the PG error reported.
    I get in place a "No results" answer, like if my request was good but give no result.

It's a huge regression.

@camsaul camsaul self-assigned this May 11, 2019
@camsaul camsaul added the Type:Bug Product defects label May 11, 2019
@camsaul camsaul added this to the 0.32.8 milestone May 11, 2019
@camsaul camsaul added Database/Postgres Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness labels May 13, 2019
@camsaul
Copy link
Member

camsaul commented May 13, 2019

Fixed by #9958. We will be releasing this as part of 0.32.8 later today.

@camsaul camsaul closed this as completed May 13, 2019
@lachesis
Copy link

lachesis commented Jun 5, 2019

Thanks for the fix. I suggest updating the patch notes for 0.32.8 to include this issue - the existing "i18n fixes" made me assume this update was not worth applying immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Database/Postgres Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

3 participants