Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update personal collection name when user name is updated #11379

Merged
merged 5 commits into from Jan 7, 2020
Merged

Update personal collection name when user name is updated #11379

merged 5 commits into from Jan 7, 2020

Conversation

lins05
Copy link
Contributor

@lins05 lins05 commented Nov 23, 2019

This shall fix #9863

@lins05 lins05 requested a review from camsaul as a code owner November 23, 2019 00:55
@lins05 lins05 mentioned this pull request Nov 23, 2019
Closed
@lins05
Copy link
Contributor Author

lins05 commented Nov 28, 2019

ping @camsaul . Any chance to take a look?

@mazameli
Copy link
Contributor

mazameli commented Dec 2, 2019

Sorry for the delay, @lins05. We'll see if we can look at this today or in the next few days. Thanks for the contribution!

@lins05
Copy link
Contributor Author

lins05 commented Dec 17, 2019

Ping again :D

@mazameli
Copy link
Contributor

@walterl, @flyingmachine, or @sbelak — mind giving this a look?

@walterl walterl self-requested a review December 19, 2019 17:32
walterl
walterl suggested changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@walterl walterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for taking the time to do this.

Functionally it looks great! I just have a few style/cosmetic suggestions.

src/metabase/models/collection.clj Outdated Show resolved Hide resolved
test/metabase/api/user_test.clj Outdated Show resolved Hide resolved
test/metabase/api/user_test.clj Show resolved Hide resolved
test/metabase/api/user_test.clj Outdated Show resolved Hide resolved
test/metabase/api/user_test.clj Outdated Show resolved Hide resolved
walterl
walterl suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@walterl walterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last little change.

test/metabase/api/user_test.clj Outdated Show resolved Hide resolved
walterl
walterl approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@walterl walterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thanks again for this contribution.

@walterl walterl merged commit 2b3575f into metabase:master Jan 7, 2020
@lins05 lins05 deleted the update-personal-collection-name branch January 8, 2020 01:10
@lins05
Copy link
Contributor Author

lins05 commented Jan 8, 2020

Thanks @walterl !

@flamber flamber mentioned this pull request Feb 19, 2021
Closed
@flamber flamber mentioned this pull request May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterl walterl walterl approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Personal collection name does not change when changing user name
3 participants
@lins05 @mazameli @walterl