Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Selenium and Karma #13401

Merged
merged 5 commits into from Oct 8, 2020
Merged

Remove Selenium and Karma #13401

merged 5 commits into from Oct 8, 2020

Conversation

nemanjaglumac
Copy link
Member

@nemanjaglumac nemanjaglumac commented Oct 8, 2020 •
edited

Status

READY

What does this PR accomplish?

  • removes Selenium and Webchauffeur
  • removes Karma with its dependencies
    • removes karma test group from CI
    • converts old frontend/test/legacy-karma/lib/dom.spec.js into a unit test frontend/test/metabase/lib/dom.unit.spec.js and skips removes 2 tests in that group (lack of support for testing selection API in div/contenteditable)
  • closes Remove Selenium and Karma #13384

How to test this manually?

  • yarn test-unit (all tests should pass)

alternatively

  • yarn test-unit-watch dom (runs the single spec frontend/test/metabase/lib/dom.unit.spec.js)
    • 1 test should pass 2 should be skipped

Additional context:

@nemanjaglumac nemanjaglumac self-assigned this Oct 8, 2020
Nemanja added 2 commits October 8, 2020 04:56
Remove karma [ci skip]
64fb241 
Note: a huge help was [this](8986c45) unmerged commit by Tom Robinson.
Remove webchauffeur
25e4cde
@nemanjaglumac nemanjaglumac changed the title Remove Selenium and Karma [ci skip] Remove Selenium and Karma Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited

Codecov Report

Merging #13401 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13401   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files         326      326           
  Lines       25968    25968           
  Branches     1892     1891    -1     
=======================================
  Hits        21567    21567           
- Misses       2509     2510    +1     
+ Partials     1892     1891    -1
Impacted Files Coverage Δ
src/metabase/models/query.clj 85.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec7307...e2eee14. Read the comment docs.

@nemanjaglumac nemanjaglumac marked this pull request as ready for review October 8, 2020 13:25
paulrosenzweig
paulrosenzweig approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@paulrosenzweig paulrosenzweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I love that diff stat +43 −871

frontend/test/metabase/lib/dom.unit.spec.js Outdated

// NOTE (based on original Tom Robinson's note from 1/7/2019):
// this worked in karma but jsdom doesn't have the required APIs on div/contenteditable
xit("should get/set selection on contenteditable correctly", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these tests can be deleted rather than skipped? Our Cypress test of custom expressions somewhat covers this.

In general, I'd say this unit-level coverage is good, but given the browser APIs required, I think relying on Cypress is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaic, even better :)

@kdoh
Copy link
Member

kdoh commented Oct 8, 2020

Very excited about this. 🥳

@nemanjaglumac
Copy link
Member Author

@dacort How is this still waiting on ci/circleci fe-tests-karma if I deleted them from the config file? 🤔

Temporarily skip Cypress flake
e2eee14 
(blocking the merge of #13401)
@dacort
Copy link
Contributor

dacort commented Oct 8, 2020

@dacort How is this still waiting on ci/circleci fe-tests-karma if I deleted them from the config file? 🤔

Not sure - maybe the checks below are still using the config from the target branch? It looks like in your individual commits, the fe-tests-karma weren't running...

@nemanjaglumac
Copy link
Member Author

Can we force merge, if all other tests pass?

@dacort
Copy link
Contributor

dacort commented Oct 8, 2020

Yep, just need an admin to do it.

@nemanjaglumac
Copy link
Member Author

Yep, just need an admin to do it.

That would be... @camsaul ? All tests finally passed. Please squash and merge this into master. Thanks 🙏

@kdoh kdoh merged commit fe545c6 into master Oct 8, 2020
@kdoh kdoh deleted the remove-selenium-karma branch October 8, 2020 17:20
robdaemon pushed a commit that referenced this pull request Oct 9, 2020
@nemanjaglumac
Remove Selenium and Karma (#13401)
1d17140 
* Remove Selenium from the project [ci skip]

* Remove karma [ci skip]

Note: a huge help was [this](8986c45) unmerged commit by Tom Robinson.

* Remove webchauffeur

* Remove unsupported tests

* Temporarily skip Cypress flake

(blocking the merge of #13401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrosenzweig paulrosenzweig paulrosenzweig approved these changes

@dacort dacort Awaiting requested review from dacort

Assignees

@nemanjaglumac nemanjaglumac

Labels
.CI & Tests Type:Tech Debt or Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Selenium and Karma
4 participants
@nemanjaglumac @kdoh @dacort @paulrosenzweig