[Actions] Add emitter and action tests #24199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`with-temp*` allows for unpaired bindings if you just want the default model. This would break the `let` that the hook was binding if you had an unpaired temp model followed by others.
Test hydration of :emitters Test hydration of :action Test http emitter execution Test emitter crud Test failure cases around emitter execution Small consistency changes made to non-test code that shouldn't affect happy path FE code, largely 404 checking and keyword/string consistency.
snoe
commented
Jul 21, 2022
| @@ -2,7 +2,7 @@ | |||
| :show-docs-arity-on-same-line? true | |||
| :project-specs [{:project-path "deps.edn" | |||
| :classpath-cmd ["clojure" "-A:dev:ee:ee-dev:drivers:drivers-dev" "-Spath"]}] | |||
|
|
|||
| :clean {:ns-inner-blocks-indentation :keep} | |||
There was a problem hiding this comment.
this prevent namespaces from changing
(:require [...])
to
(:require
[...])
snoe
commented
Jul 21, 2022
| part (:children binding+opts)] | ||
| ;; if children is size 1 then ensure nil is on the right side of the let | ||
| :let [[binding-part opts] (:children binding+opts)] | ||
| part [binding-part opts]] |
There was a problem hiding this comment.
this fixes bad analysis when with-temp* doesn't use a pair of values for the model.
(mt/with-temp [Action [a] HttpAction [b {}]] ...)
This was expanding into [[Action HttpAction] (let [a b {}] ...)] but should now turn into [[Action HttpAction] (let [a nil b {}] ...)]
Codecov Report
@@ Coverage Diff @@
## pod-writeback #24199 +/- ##
=================================================
+ Coverage 64.34% 64.57% +0.22%
=================================================
Files 2773 2783 +10
Lines 85443 86477 +1034
Branches 10631 10687 +56
=================================================
+ Hits 54978 55841 +863
- Misses 26157 26272 +115
- Partials 4308 4364 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
camsaul
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24079
Adding tests for emitters and actions
Test hydration of :emitters
Test hydration of :action
Test http emitter execution
Test emitter crud
Test failure cases around emitter execution
Small consistency changes made to non-test code that shouldn't affect happy path FE code, largely 404 checking and keyword/string consistency.