fix modal content display #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VikramTiwari
added a commit
to VikramTiwari/metabase
that referenced
this pull request
Mar 26, 2017
* master: (66 commits) Fix flow error and remove old unused files minor change clean up pulse empty state modals (metabase#4422) use MetaBot's proper name to avoid a robot rebellion (metabase#4501) Separate embed entrypoint with licenses Add embed title option, change share widget tooltip text Fix part 2 🔧 Make sure to remove :parameters not present in embedding-params Test fix 🔧 Lint fix 👕 Test fixes 🔧 include disclaimer Disallow :alg = :none and test initial embedding EULA produce valid python dictionaries fix modal content display (metabase#4476) Return non-generic error messages for /embed endpoints Make sure embed frontend shows errors from server Fix new Table entries being added if a Table or View is dropped and recreated Druid test fix 🔧 [ci drivers] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4456