Fix the expression editor in recent versions of Chrome and Firefox #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hawt. That sorta kinda makes sense. Why is Safari different? Or is it just behind? |
salsakran
approved these changes
May 5, 2017
|
Did anyone test it? I tried to patch this on 0.23.1 without any success. |
|
Definitely is working for me on this branch. I haven't tried patching on 0.23 but I don't know why it wouldn't work.
|
attekei
approved these changes
May 5, 2017
|
Just tried cherry-picking onto v0.23.1 and confirmed it works there too: |
|
I tried the branch and it works locally. |
|
It worked! Not sure why it did not work earlier. Could have been cache on the browser side. |
kdoh
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4906
Apparently in recent versions of FF and Chrome
window.getSelection().getRangeAt(0).setStart(element, 0);will actually mutate the live selection, which is cool, but not what the previous code expected.