New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim user name before set #6519

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@iamkyu
Contributor

iamkyu commented Dec 2, 2017

I think that in most cases it is a human error that a blank before or after an email is included.
So I added trim processing.

closes #4439

@camsaul

This comment has been minimized.

Show comment
Hide comment
@camsaul

camsaul Dec 21, 2017

Member

this makes sense to me

@kdoh does this work for you?

Member

camsaul commented Dec 21, 2017

this makes sense to me

@kdoh does this work for you?

@camsaul

👍 but want to get @kdoh's thoughts too

@camsaul camsaul added the CLA/Signed label Dec 21, 2017

@kdoh

This comment has been minimized.

Show comment
Hide comment
@kdoh

kdoh Dec 21, 2017

Member

LGTM

Member

kdoh commented Dec 21, 2017

LGTM

@camsaul camsaul merged commit 3444e57 into metabase:master Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment