Hydrate dash id keys#10
Merged
Merged
Conversation
java.sql.Timestamp/valueOf converts between local time and UTC, so the result can be different when using #inst, depending on your timezone.
When hydrating, check for keys ending in either _id or -id. Fixes metabase#6
Arguments to `some` were in the wrong order. Added a test for `automagically-batched-hydrate` so this won't happen again.
Member
|
@plexus this looks great, I'll play around with it and then if it all looks good I'll hit merge |
Member
|
Looks good. Thanks for the contribution |
Member
|
@plexus I've released version 1.0.3 which includes your changes. |
Contributor
Author
|
Great! Thanks for the quick response 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hydrating, check for keys ending in either _id or -id.
Also fixes a test that would fail depending on the timezone.
Closes #6.