Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrate dash id keys #10

Merged
merged 3 commits into from May 3, 2017
Merged

Hydrate dash id keys #10

merged 3 commits into from May 3, 2017

Conversation

@plexus
Copy link
Contributor

@plexus plexus commented May 3, 2017

When hydrating, check for keys ending in either _id or -id.

Also fixes a test that would fail depending on the timezone.

Closes #6.

plexus added 3 commits May 3, 2017
java.sql.Timestamp/valueOf converts between local time and UTC, so the
result can be different when using #inst, depending on your timezone.
When hydrating, check for keys ending in either _id or -id.

Fixes #6
Arguments to `some` were in the wrong order. Added a test for
`automagically-batched-hydrate` so this won't happen again.
@camsaul
Copy link
Member

@camsaul camsaul commented May 3, 2017

@plexus this looks great, I'll play around with it and then if it all looks good I'll hit merge

@camsaul
Copy link
Member

@camsaul camsaul commented May 3, 2017

Looks good. Thanks for the contribution

@camsaul camsaul merged commit bc7de9f into metabase:master May 3, 2017
@camsaul
Copy link
Member

@camsaul camsaul commented May 3, 2017

@plexus I've released version 1.0.3 which includes your changes.

@plexus plexus deleted the plexus:hydrate-dash-id-keys branch May 3, 2017
@plexus
Copy link
Contributor Author

@plexus plexus commented May 3, 2017

Great! Thanks for the quick response 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.