Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB-338: Create MusicBrainz schema in AcousticBrainz database #271

Merged

Conversation

@rsh7
Copy link
Contributor

@rsh7 rsh7 commented May 26, 2018

For implementing the method of copying the relevant information from MB database into a separate schema in AB database, this PR includes the addition of a new musicbrainz schema in AB and add a create table sql script.

@rsh7 rsh7 force-pushed the rsh7:musicbrainz_schema branch 2 times, most recently from 03c88a5 to 1fd8758 Jun 4, 2018
@rsh7 rsh7 changed the base branch from master to musicbrainz-integration-gsoc Jun 5, 2018
@paramsingh
Copy link
Member

@paramsingh paramsingh commented Jun 5, 2018

rebase this please.

@rsh7 rsh7 force-pushed the rsh7:musicbrainz_schema branch from f56df41 to 402bec2 Jun 5, 2018
Copy link
Member

@paramsingh paramsingh left a comment

I'd like to keep the musicbrainz schema independent of the core AB database (keeping it optional). Could you move the musicbrainz schema, tables, primary and foreign keys and indexes to their own files and add a command to init the musicbrainz db to manage.py?

@@ -154,4 +154,273 @@ CREATE TABLE feedback (
suggestion TEXT
);


CREATE SCHEMA IF NOT EXISTS musicbrainz;

This comment has been minimized.

@paramsingh

paramsingh Jun 6, 2018
Member

this should be done in create_musicbrainz_schema.sql.

This comment has been minimized.

@rsh7

rsh7 Jun 7, 2018
Author Contributor

Done!

@rsh7 rsh7 force-pushed the rsh7:musicbrainz_schema branch from 402bec2 to b4a41b9 Jun 7, 2018
@rsh7
Copy link
Contributor Author

@rsh7 rsh7 commented Jun 7, 2018

Added the new files for MusicBrainz schema, tables, indexes, primary and foreign keys and a function in manage.py to init the MB database along with creating the table structure and keys.

@paramsingh paramsingh merged commit 9682dd6 into metabrainz:musicbrainz-integration-gsoc Jun 7, 2018
1 check passed
1 check passed
@brainzbot
Jenkins Build finished.
Details
@rsh7 rsh7 deleted the rsh7:musicbrainz_schema branch Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants