Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB-356: Redirects MBID to it's original entity using musicbrainz data for recording entity #291

Merged

Conversation

@rsh7
Copy link
Contributor

@rsh7 rsh7 commented Jul 28, 2018

An integration to actually work with musicbrainz data over faster access. This PR consists of a script which takes mbids as input and results in redirecting the MBID of an entity to it's original entity.

@rsh7 rsh7 changed the base branch from master to musicbrainz-integration-gsoc Jul 28, 2018
@rsh7
Copy link
Contributor Author

@rsh7 rsh7 commented Jul 28, 2018

@paramsingh, I have added the function call in manage.py script for now. I will change it accordingly when we would work on the testing scripts for evaluating both methods.

Loading

for mbid in mbids:
recording_mbids.append(str(mbid[0]))

gids_with_redirected_ids = get_original_entity(recording_mbids)
Copy link
Member

@paramsingh paramsingh Jul 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function isn't returning anything, have you run this code before sending the PR? Is it not used?

Loading

Copy link
Contributor Author

@rsh7 rsh7 Jul 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part of MBID redirect is to use the information to determine when two distinct MBIDs in the database refer to the same recording.
So, I am storing the result in the form of dictionary with keys as MBIDs and values as ids of the recording to which it is redirected to.
And we can use this information to implement any functionality in future and for now we would use it for evaluating 2 methods of db access

Loading

Copy link
Member

@paramsingh paramsingh Aug 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that, but the function should still return gids_with_redirected_ids

Loading

Copy link
Contributor Author

@rsh7 rsh7 Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Loading

@paramsingh paramsingh force-pushed the musicbrainz-integration-gsoc branch from a5f4506 to 7e7bda1 Aug 5, 2018
@rsh7 rsh7 force-pushed the mbid_redirects branch from a9e2179 to 82708fe Aug 5, 2018
@rsh7
Copy link
Contributor Author

@rsh7 rsh7 commented Aug 5, 2018

Rebased this with the base branch. 👍

Loading

@rsh7
Copy link
Contributor Author

@rsh7 rsh7 commented Aug 6, 2018

@paramsingh, error in function dump.import_db_dump(path)
file - db/test/test_dump.py
It is related to one of your recent PRs I guess.

Loading

@paramsingh
Copy link
Member

@paramsingh paramsingh commented Aug 7, 2018

@brainzbot retest this please

Loading

@paramsingh paramsingh merged commit f63e854 into metabrainz:musicbrainz-integration-gsoc Aug 7, 2018
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants