Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
AB-394 - Bulk get items with a single database query #337
Single database query for low-level data of many recordings
Check for database query method in endpoint query string
API endpoint get_many_lowlevel takes optional parameter to specify
Single query implemented for low-level data
Single query uses subquery to partition recordings and attach
@alastair This pull request contains the single query method for AB-394. Still a work in progress but I think it would be beneficial to discuss the current state of the query, and how I can approach testing it on a larger scale. Thus far, I've tested the query with 40-50 recordings and seen ~11% improvement in the speed at this small scale. I still need to do unit testing for this work as well (as soon as I get some breathing room from my exams this week).
One other thing I noticed: when adding offsets to a query string, if you specify an offset that does not exist (out of range for recordings in the db), the api just returns data for all other recordings but makes no note that one is missing. I feel as though the functionality of this endpoint might be improved with an error message for an offset out of range, or something to that effect?
alastair left a comment
Thanks, good to see that we can get something working. I think we should make a few changes to the query, and some cleanups to the way that we call the db methods from the view