Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
BU-11: Add MusicBrainz database module to brainzutils #14
MusicBrainz DB is being used by more than one MB projects (CritiqueBrainz, AcousticBrainz) for useful information and MessyBrainz also needs this.
The code for accessing different entities can be shared by using brainzutils musicbrainz_db module.
Created musicbrainz_db module.
2 similar comments
referenced this pull request
May 15, 2018
Looks pretty good to me.
I have a few points that should be addressed before this can be merged. The serialize entities stuff is not documented or tested really. Since your project only needs recordings right now, I think we should test and document that, while moving the other serialization functions to a different ticket and PR.
Another point that I think we should consider is moving all caching related stuff out of this module. I tried this locally and the first error I got was that cache wasn't initiated. We should let other projects handle caching while keeping this module exclusively for database access.