Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BU-13: Use direct MB database access for artist entity #15

Merged
merged 3 commits into from Jun 4, 2018

Conversation

Projects
None yet
3 participants
@rsh7
Copy link
Contributor

rsh7 commented May 15, 2018

Add the direct access of MB database for artist entity and add tests too. Contains function for getting artist by mbid and fetch multiple artists using mbids.

@brainzbot

This comment has been minimized.

Copy link
Member

brainzbot commented May 15, 2018

Can one of the admins verify this patch?

2 similar comments
@brainzbot

This comment has been minimized.

Copy link
Member

brainzbot commented May 15, 2018

Can one of the admins verify this patch?

@brainzbot

This comment has been minimized.

Copy link
Member

brainzbot commented May 15, 2018

Can one of the admins verify this patch?

@paramsingh

This comment has been minimized.

Copy link
Member

paramsingh commented May 15, 2018

@brainzbot, add to whitelist

@paramsingh
Copy link
Member

paramsingh left a comment

Let's remove the caching logic from this module. Projects should not depend on brainzutils.musicbrainz_db for caching.

@rsh7 rsh7 force-pushed the rsh7:artist_entity branch from 74ce6fd to 55c6957 Jun 4, 2018

@paramsingh
Copy link
Member

paramsingh left a comment

🥇

@paramsingh paramsingh merged commit bd85467 into metabrainz:master Jun 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.