New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-231: Use direct database access for entity: place #110

Merged
merged 2 commits into from Jul 4, 2017

Conversation

Projects
None yet
2 participants
@ferbncode
Collaborator

ferbncode commented Jun 19, 2017

Use direct database access for entity place. I have added functions entity_relation_helper and get_place_by_id for fetching information regarding place.

@gentlecat

This comment has been minimized.

Show comment
Hide comment
@gentlecat

gentlecat Jun 19, 2017

Contributor

Have you considered using mbdata package for this purpose?

Contributor

gentlecat commented Jun 19, 2017

Have you considered using mbdata package for this purpose?

@ferbncode ferbncode changed the title from [WIP]: CB-231: Use direct database access for entity: place to CB-231: Use direct database access for entity: place Jun 26, 2017

@gentlecat

This comment has been minimized.

Show comment
Hide comment
@gentlecat

gentlecat Jun 26, 2017

Contributor

Haven't been able to test this due to problems with the MusicBrainz database image setup. https://chatlogs.metabrainz.org/brainzbot/metabrainz/2017-06-26/?msg=3940782&page=2

Contributor

gentlecat commented Jun 26, 2017

Haven't been able to test this due to problems with the MusicBrainz database image setup. https://chatlogs.metabrainz.org/brainzbot/metabrainz/2017-06-26/?msg=3940782&page=2

@gentlecat

Seems to be working. Awesome!

@gentlecat gentlecat merged commit dc9f9ab into metabrainz:master Jul 4, 2017

1 check passed

Jenkins Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment