New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-231: Update db access function and helpers for multiple entities. #121

Merged
merged 3 commits into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@ferbncode
Collaborator

ferbncode commented Jul 5, 2017

Updated entity_relation_helper and get_place_by_id to fetch info for multiple entities. Function fetch multiple places can be used to fetch info of multple places.

@alastair

Some of these methods are getting complex to understand - especially now that you've changed the behaviour but kept the method names. Consider renaming the methods.

@gentlecat

This comment has been minimized.

Show comment
Hide comment
@gentlecat

gentlecat Jul 14, 2017

Contributor

Apologies for breaking the tests and causing conflicts, but there were some important issues I had to fix. Please rebase this on top of latest master when you can.

Thanks!

Contributor

gentlecat commented Jul 14, 2017

Apologies for breaking the tests and causing conflicts, but there were some important issues I had to fix. Please rebase this on top of latest master when you can.

Thanks!

@gentlecat

This comment has been minimized.

Show comment
Hide comment
@gentlecat

gentlecat Jul 19, 2017

Contributor

@alastair, can you please check the changes?

Contributor

gentlecat commented Jul 19, 2017

@alastair, can you please check the changes?

@alastair

Looks good to me now

@gentlecat gentlecat merged commit 921b514 into metabrainz:master Jul 19, 2017

2 checks passed

Jenkins Build finished.
Details
Jenkins [PyLint] Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment