CB-270: Implemented the reviewal of artists #263
Conversation
|
Let's start this as well. Could you fix the conflicts? |
|
Merge conflict resolved. |
|
This is already good. If we could support coverart, it would be awesome, but it seems that the coverart API supports only release and release-groups at the moment. However, do you think you can add a tab or list of existing reviews for an artist. |
|
@ferbncode So something like this?
|
|
@spellew The third one looks good. We can limit to 5 reviews to show on artist page if there are many reviews. But the third one looks good, being outside the discography and very similar to release group pages.. What do you think? |
|
@ferbncode I also like the third one, but I'm not sure if users having to scroll down to view the discography is a problem or not? If we limit it to five, we'd have arrows on the left or right, allowing users to view the next or previous reviews? |
|
@spellew I think there could be a link "See all reviews for"Artist"" which would list all the remaining reviews on the same page? If we find its not what users expect, we can come back again to fix it. |
|
@ferbncode That sounds good to me. |
|
@spellew That looks good IMO :) |
Changes have been pushed. |
| @@ -25,29 +25,42 @@ def entity(mbid): | |||
| # Note that some artists might not have a list of members because they are not a band | |||
| band_members = _get_band_members(artist) | |||
|
|
|||
| reviews_limit = 5 | |||
There was a problem hiding this comment.
Let's make it configurable as a constant at the beginning of the file (and release_group_limit as well) :)
There was a problem hiding this comment.
Can I get an example of what this would look like? I've attempted placing the constants at the beginning of the file, under the imports, but I keep getting UnboundLocalError: local variable referenced before assignment.
There was a problem hiding this comment.
You can place then in __init__.py and then import the variables?
|
@paramsingh When you get time, could you merge this and deploy to beta.critiquebrainz.org? Thanks in advance! :) |
|
I've deployed it on beta, thanks for all the great work! |
No description provided.