Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-270: Implemented the reviewal of works #266

Merged
merged 13 commits into from Aug 29, 2019

Conversation

@spellew
Copy link
Contributor

commented Jun 16, 2019

No description provided.

@spellew

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@ferbncode Updated this pull request. Here is what the work page currently looks like.

Screenshot_2019-08-15 Halo - CritiqueBrainz

@ferbncode
Copy link
Collaborator

left a comment

@spellew Minor nitpick. I think adding showing some metadata like type (just beside the title like year in release group pages.) should also be done for works' entity pages. I see that you've already added relationships and recordings 👍 , let's add the type in the entity pages :)

@spellew

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

@ferbncode How does this look?

Screenshot_2019-08-17 Halo - CritiqueBrainz

@ferbncode

This comment has been minimized.

Copy link
Collaborator

commented Aug 18, 2019

@spellew looks good to me.

@spellew

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

@ferbncode Updated the title here too.

@paramsingh paramsingh merged commit 595110d into metabrainz:master Aug 29, 2019

2 checks passed

Jenkins [PyLint & Flake8] Build finished.
Details
Jenkins [PyTest] Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.