Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-357: Artist review creation page title does not have artist name #271

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@spellew
Copy link
Contributor

commented Aug 7, 2019

@spellew spellew changed the title CB-357 Artist review creation page title does not have artist name CB-357: Artist review creation page title does not have artist name Aug 7, 2019

@paramsingh
Copy link
Member

left a comment

Let's make tests pass, do the changes we discussed on irc and add tests.

@ferbncode

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

@spellew @paramsingh Thanks for fixing the tests.

@spellew

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@paramsingh Updated to set entity_title outside of the template.

@paramsingh paramsingh merged commit 37c3373 into metabrainz:master Aug 14, 2019

2 checks passed

Jenkins [PyLint & Flake8] Build finished.
Details
Jenkins [PyTest] Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.