Fix ignoring some files when building Docker images #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patterns are incorrectly following .gitignore format which is different. The main change is root directory / is implicit in .dockerignore format. See https://docs.docker.com/engine/reference/builder/#dockerignore-file This patch fixes/extends existing patterns as follows: * Adding a / in front of patterns matching subpaths of root directory. (Even though it is not required, it is less treacherous to git users.) * Adding **/ in front of patterns matching subpaths of any directory. (This captures a lot more of *.pyc files and __pycache__/ dirs.)
Even though it is not strictly required, ending a path with a `/` makes clear that only directories are supposed to be ignored by Docker build.
When creating a Docker image, skip all: - `/.git*` such as .gitattributes .gitignore .github - `/env*/` `/venv*/` `/build*/` such as venv-py39
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
yvanzo
changed the title
|
@brainzbot add to whitelist |
|
So that I understand this better - the main issue is that something like
only refers to a directory ./pycache in the root directory, and not in any other subdirectory? For this reason you've explicitly prefixed a |
|
@alastair: Exactly, see also commits message and linked documentation. It makes a difference mainly when building from a developer’s working local copy. |
|
Note that |
This was referenced Jan 9, 2021
alastair
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Patterns in the
.dockerignorefile are incorrectly following.gitignoreformat.The main difference is that root directory
/is implicit in.dockerignoreformat.See https://docs.docker.com/engine/reference/builder/#dockerignore-file for reference.
This leads to not ignoring a bunch of files when building Docker images.
It can make Docker images to be larger than necessary or to contain unintended data.
Solution
.gitignoresyntax by explicitly prepending with/to match from the root directory only (default) or with**/to match from any subdirectory (and from the root directory too)./to specify when ignoring directories.gitattributes,venv-py39…That pull request follows commit metabrainz/sir@c03d568 whihc addresses the same issue in SIR.
Action