New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #288

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
@jwflory
Contributor

jwflory commented Nov 11, 2017

Summary

Adds a pull request template that auto-fills the text box when making a new pull request.

Analysis

The goal is to make it easier for project members to review contributions to the project. We want to guide people to give us helpful information that they might not think to add. Making sure we ask for actually helpful advice is important.

I look to @mayhem and @paramsingh again for review on this one. Is there anything we want to add, change, or remove?

Edit: The Travis CI build is failing because of metabrainz/brainzutils-python#6, I think.

@paramsingh

paramsingh approved these changes Nov 11, 2017 edited

Looks good to me, however one thing I'd like is to put the first two paragraphs that should not be in actual PRs in comments like in the bookbrainz PR template: https://raw.githubusercontent.com/bookbrainz/bookbrainz-site/master/.github/PULL_REQUEST_TEMPLATE.md

Also, if we're aiming for consistency, having the same fields as the BB PR template might be a good idea, although the current fields look good enough to me.

@mayhem mayhem merged commit 5ef3502 into metabrainz:master Nov 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jwflory jwflory deleted the jwflory:add/pr-template branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment