Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for tracknumber field in data #574

Merged
merged 1 commit into from May 22, 2019

Conversation

@paramsingh
Copy link
Member

commented May 22, 2019

Users were submitting tracknumbers as strings, we should convert them to integers before sending them to influx.

@paramsingh paramsingh force-pushed the paramsingh:influx-bug branch from 86f059b to 3ae4183 May 22, 2019
@paramsingh paramsingh force-pushed the paramsingh:influx-bug branch from 3ae4183 to 14111a9 May 22, 2019
@mayhem
mayhem approved these changes May 22, 2019
Copy link
Member

left a comment

Fix looks good. I will fix the test and merge on my machine.

@mayhem mayhem merged commit 14111a9 into metabrainz:master May 22, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.