Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-123: Setup Docker for MessyBrainz #18

Merged
merged 5 commits into from May 31, 2017

Conversation

Projects
None yet
3 participants
@paramsingh
Copy link
Member

commented May 28, 2017

Almost all of the stuff taken from LB. Had to fix some tests as well.

paramsingh added some commits May 28, 2017

Setup docker for MessyBrainz
Add a docker-compose.yml, a Dockerfile and change some stuff in
manage.py so that db is set up inside docker
Add compose file for tests and test.sh
Also remove an unused import which was causing tests to fail
and add pytest to requirements
@mayhem

mayhem approved these changes May 29, 2017

Copy link
Member

left a comment

Looks good to me. Unless Alastair has comments, lets merge this and then do LB-160.

@paramsingh

This comment has been minimized.

Copy link
Member Author

commented May 29, 2017

I have the LB-160 patch ready to send as soon as this gets merged.

@alastair alastair self-assigned this May 29, 2017

@alastair
Copy link
Contributor

left a comment

Nice 🌵

@@ -0,0 +1,34 @@
FROM python:2.7.12

This comment has been minimized.

Copy link
@alastair

alastair May 31, 2017

Contributor

I guess the idea is that we switch this to python3 once this PR is merged?

This comment has been minimized.

Copy link
@paramsingh

paramsingh May 31, 2017

Author Member

Yep.

README.md Outdated
Everything should be good to go now. You should be able to access the webserver at `http://localhost:8080`.

Also, in order to run the tests, just use the command: `./test.sh`.

### The Usual Way

Full installation instructions are available in [INSTALL.md](https://github.com/metabrainz/messybrainz-server/blob/master/INSTALL.md) file.

This comment has been minimized.

Copy link
@alastair

alastair May 31, 2017

Contributor

Do we need to have normal installation instructions? I'm happy to force everyone to use Docker

This comment has been minimized.

Copy link
@paramsingh

paramsingh May 31, 2017

Author Member

Not really, I'll remove it.

@@ -0,0 +1,130 @@
#!/bin/bash

This comment has been minimized.

Copy link
@alastair

alastair May 31, 2017

Contributor

We're now sharing these scripts among multiple projects. I wonder if it's a good idea that we make a separate project for them and git submodule them in for use by each project. Then our test.sh can just import this file and set a few variables.

Remove normal install instructions
Docker is the only supported install method now.

@mayhem mayhem merged commit 1972b54 into metabrainz:master May 31, 2017

@paramsingh paramsingh deleted the paramsingh:docker-setup branch May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.