Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-10108: Allow linking tweets to recordings only #1080

Merged
merged 2 commits into from May 23, 2019

Conversation

@yvanzo
Copy link
Contributor

commented May 22, 2019

MBS-10108: Allow linking tweets to recordings only

Handle Twitter update permalinks such as https://twitter.com/user/status/123:

  • auto-select “stream music for free” relationship type,
  • same cleanup as for linking to Twitter accounts,
  • validate linking Twitter updates to recordings only.

See https://blog.twitter.com/en_us/a/2006/twitter-has-permalinks-and-rss-feeds.html

@reosarevok

This comment has been minimized.

Copy link
Member

commented May 22, 2019

I guess having the cleanup be shared would be tricky if at all possible and it's not that big an extra amount of code, so that should be fine.

@yvanzo yvanzo changed the title MBS-10108: MBS-10108: Allow linking tweets to recordings only May 22, 2019
@yvanzo

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

@reosarevok Found the trick, let me know which version you prefer.

@yvanzo yvanzo requested a review from reosarevok May 22, 2019
@yvanzo yvanzo force-pushed the yvanzo:mbs-10108-tweet-rec branch from 36e7b43 to e8cd7b0 May 23, 2019
Handle Twitter update permalinks https://twitter.com/user/status/123

* auto-select “stream music for free” relationship type,
* same cleanup as for linking to Twitter accounts,
* validate linking Twitter updates to recordings only,

See https://blog.twitter.com/en_us/a/2006/twitter-has-permalinks-and-rss-feeds.html
@yvanzo yvanzo force-pushed the yvanzo:mbs-10108-tweet-rec branch from e8cd7b0 to 334053e May 23, 2019
@yvanzo yvanzo marked this pull request as ready for review May 23, 2019
@yvanzo yvanzo merged commit c585db7 into metabrainz:master May 23, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: js Your tests passed on CircleCI!
Details
ci/circleci: perl-and-pgtap Your tests passed on CircleCI!
Details
ci/circleci: selenium Your tests passed on CircleCI!
Details
@yvanzo yvanzo deleted the yvanzo:mbs-10108-tweet-rec branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.