Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-10370: Add "direction: forward" to XML WS rels #1212

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@reosarevok
Copy link
Member

reosarevok commented Sep 17, 2019

https://tickets.metabrainz.org/browse/MBS-10370

The JSON WS already outputs direction either way, but the XML one only outputs direction if it's backward. mmd specifies forward is allowed, so this should cause no issues.

@reosarevok reosarevok requested review from mwiencek and yvanzo Sep 17, 2019
@reosarevok reosarevok force-pushed the reosarevok:MBS-10370 branch from 44b7ffd to c3f979a Sep 17, 2019
Copy link
Member

mwiencek left a comment

This conflicts with #1201 but we can work that out whenever either is merged

@reosarevok reosarevok added the QoL label Sep 27, 2019
@reosarevok reosarevok added this to the Baby Shark milestone Oct 2, 2019
The JSON WS already outputs direction either way, but the XML one only
outputs direction if it's backward. mmd specifies forward is
allowed, so this should cause no issues.
@reosarevok reosarevok force-pushed the reosarevok:MBS-10370 branch from c3f979a to 1ad13df Oct 3, 2019
@reosarevok

This comment has been minimized.

Copy link
Member Author

reosarevok commented Oct 3, 2019

Conflicts fixed.

@yvanzo
yvanzo approved these changes Oct 7, 2019
Copy link
Contributor

yvanzo left a comment

Thank you! 🚢

@reosarevok reosarevok merged commit 26e23f4 into metabrainz:master Oct 7, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: js Your tests passed on CircleCI!
Details
ci/circleci: perl-and-pgtap Your tests passed on CircleCI!
Details
ci/circleci: selenium Your tests passed on CircleCI!
Details
@reosarevok reosarevok deleted the reosarevok:MBS-10370 branch Oct 7, 2019
mwiencek added a commit that referenced this pull request Oct 8, 2019
* master:
  Handle selenium http-proxy errors without dying
  Bump http-proxy to 1.18.0
  MBS-10370: Add "direction: forward" to XML WS rels (#1212)
  MBS-10355: Display track artist on recording pages (#1207)
  MBS-4980: Use catnos to sort releases in RG page (#1185)
  MBS-5479: Add an "Edit Relationships" tab (#1219)
  MBS-4913: Indicate the number of CAA pieces on tab (#1175)
  MBS-10263: Don't insert annotation if edit is open
  Remove unused add_event_annotation.tt
  MBS-4486: Remove parentheses around disambiguation (#1170)
  MBS-8566: Reuse release AC when importing CD stubs (#1193)
  Fix relationship edit credit display (#1225)
  Add ReleaseEventsDiff to root/server/components.js
  MBS-9920: Convert the recording fingerprints page to React (#1220)
  MBS-10363: Go back to referer on merge cancel (#1210)
  Make no filter result messages more consistent
  Move Filter::Recording to Filter::Generic
  MBS-9915: Convert the artist public pages to React
  MBS-8967: Events aren't dupes if all have comment (#1139)
  MBS-10369: Count descendant countries in stats (#1213)
  MBS-10411: Force coordinates as floats in JSON WS (#1223)
  MBS-10229: Block more shortened/smart URLs (#1106)
  Bump React to 16.10.2 (#1221)
  MBS-10240: Allow seeding "release has no barcode" (#1182)
  Bump Flow to 0.109.0
  MBS-10349: New, more clear headers for rel stats (#1203)
  MBS-10345: Redirect away from /merge if not ready to merge (#1198)
  MBS-10373: Link to How to Write Edit Notes above the edit note fields
  MBS-9111: Stricter validation for empty edit notes
  Remove no longer needed .actions-header
  MBS-10347: Make action columns take only needed space
  Eslint: brace-style
  Eslint: padded-blocks
  Eslint: newline-per-chained-call
  Eslint: indent
  Eslint: object-curly-spacing
  Eslint: quotes
  Eslint: quote-props
  Eslint: no-var
  Eslint: disable sort-keys for cardinalityMap
  MBS-9924: Convert work index to React
  Move CleanupBanner to its own component
  Add limit/offset to /ws/2/discid
  Remove gid sorting from WS lists
  Remove relationship sorting from JSON WS
  Cmp refaddrs in Entity::ArtistCredit::is_equal
  Load release, track, and recording ACs together
  Limit WS release lists to 500 tracks
  Limit # of cache entries per call
  Batch advisory lock calls together
  Fix pathological release loading in /ws/2/discid
  Quicker has_rels
  Use preset Moose attributes for source/target
  Use XML::LibXML for XML WS responses
  Speedup slow meta access in store
  Remove slow target_key function
  Replace slow find_attribute_by_name call with can
  Add View::WS
  Sort relationships in SQL instead of Perl
  Fix file system permissions in CircleCI config
  Compare Entity::ArtistCredit missing artist_id (#1178)
  Convert relationship edit diffs to React
  Allow entity placeholders in link phrase
  Initial port of edit Diff plugin to JavaScript
  Reorder buttons on ConfirmLayout
  Add Flow types to common/utility/clean.js
  Remove unused label arg
  Allow signaling a nameVariation in EntityLink
  Remove display_html_diff
  Don't output class="" in edit diffs
  Convert reactTextContent to ES6 module, add types
  Fix up reactTextContent
  MBS-10353: Tests for release browse ratings
  MBS-10353: Enable ratings for release browse
  Bump Flow to 0.107.0
  MBS-10346: Remove unneeded <p> inside <td>
  React autocomplete component
  Update lodash libdefs
  MBS-3112: Switch order of release editor buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.