MBS-5763: Use l_name when displaying release attributes #17

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

ocharles commented Jan 22, 2013

No description provided.

Contributor

ianmcorvidae commented Jan 22, 2013

Looks good -- did you do any sort of testing?

Contributor

ocharles commented Jan 25, 2013

Yes, but only in English as I haven't managed to get translations working here. The English page still displays correctly though, which granted - is not exactly much good because that doesn't use translations at all.

Contributor

ianmcorvidae commented Jan 25, 2013

I'll test it locally then, but -- prod me at some point and we can get your local setup working with translations, though there should be instructions in INSTALL.md -- in short, it's: install gettext if you don't have it, get .po files, make -C po && make -C po install, add languages you want to support to DBDefs (with some weird exceptions for a few common languages due to some bugs -- e.g. put in es-es even if you want just plain es), install/create system locales for the languages you want.

Contributor

ianmcorvidae commented Jan 25, 2013

Okay, this looks to work -- however, it looks like add release (and probably also remove release, realistically) aren't done; could you also do those bits?

Contributor

ocharles commented Jan 29, 2013

Done, but there are no attributes in remove release, so I've left that alone.

Contributor

ianmcorvidae commented Jan 29, 2013

🚢 thanks!

ocharles closed this Feb 3, 2013

mwiencek deleted the mbs-5763 branch Apr 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment