MBS-11700: Do not assume cdtoc_id exists #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, very old remove discID edits have a null cdtoc_id. Since we are not currently using it (I only added it here originally because we expect CDTOCs to have an ID), we can drop it again.
Some old edit notes are apparently missing post_time, which was causing an ISE when trying to load them since formatUserDate can't cope with being passed null. Rather than making formatUserDate accept null, this returns a '[time missing]' string that can at least still be used to link to the note, which wasn't possible in the TT version.
reosarevok
added
the
Regression/Beta
mwiencek
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-11700 and a second, not yet released bug
See commit messages. Both bugs apply on edit 531554.