Skip to content

/musicbrainz-server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Generasia URLs (solves MBS-8744) #361

Merged
merged 2 commits into from Oct 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yvanzo @mwiencek
@yvanzo
Copy link
Contributor

commented Sep 30, 2016 •
edited

Like most of other databases, Generasia URLs were allowed for all entity types.

This makes use of PR #354 to allow it for Artists, Labels, Release Groups, and Works only.

It prevents linking to Generasia from Releases (MBS-8744).

y-van-z added some commits Sep 30, 2016

y-van-z
Specifically validate Generasia URLs (MBS-8744) 
Previously, Generasia URLs were allowed for all entity types.

With this patch, they are only allowed for Artists, Release Groups,
Labels, and Works. It prevents linking to it from Releases (MBS-8744).
c8fe906
y-van-z
Add validation test for Generasia URLs (MBS-8744)
Loading status checks…
47de1a5

@yvanzo yvanzo force-pushed the yvanzo:mbs-8744 branch from 63c18ba to 47de1a5 Sep 30, 2016

@mwiencek

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 1, 2016

🚢

@mwiencek mwiencek merged commit 1b1072b into metabrainz:master Oct 1, 2016
1 check passed

1 check passed

Jenkins Build finished.
Details

@yvanzo yvanzo deleted the yvanzo:mbs-8744 branch Oct 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.