Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node renderer fixes #510

Merged
merged 5 commits into from May 29, 2017

Conversation

@mwiencek
Copy link
Member

mwiencek commented May 16, 2017

It wasn't much effort to fix, so here it is. Tested with the help of adhawkins.

I updated node-raven to v2 because it was impossible to even see what the errors were without it (v1 hid uncaught exceptions).

@mwiencek mwiencek requested a review from yvanzo May 16, 2017
mwiencek added 2 commits May 16, 2017
Version 2.0 has better error logging (doesn't obscure uncaught
exceptions).

The install() line had to be moved because Raven.wrap now throws an
exception if Raven isn't configured yet.
Use RegExp.prototype.test, which is supported in older versions of node.
@mwiencek mwiencek force-pushed the mwiencek:node-fixes branch 3 times, most recently from 4f13891 to 01cac55 May 17, 2017
@mwiencek mwiencek changed the title Node 0.12 fixes Node renderer fixes May 17, 2017
mwiencek added 3 commits May 16, 2017
Even though killNext and receiveData are inside functions which are
already wrapped, they're executed in different stack frames, so they
also needs to be wrapped.
Object.values is unavailable in older versions of Node.

Object.keys should be fine, but I've replaced it too for consistency.
@mwiencek mwiencek force-pushed the mwiencek:node-fixes branch from 01cac55 to 73ae08b May 17, 2017
@mwiencek mwiencek merged commit 95469fc into metabrainz:master May 29, 2017
1 check failed
1 check failed
Jenkins Build finished.
Details
@mwiencek mwiencek deleted the mwiencek:node-fixes branch May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.