Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node renderer fixes #510

Merged
merged 5 commits into from May 29, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Raven.wrap some additional functions

Even though killNext and receiveData are inside functions which are
already wrapped, they're executed in different stack frames, so they
also needs to be wrapped.
  • Loading branch information
mwiencek committed May 17, 2017
commit 0d04c561f48c567b559bddc9db3b753e3bd750b6
@@ -85,13 +85,13 @@ if (cluster.isMaster) {
}
}

const cleanup = function (signal) {
const cleanup = Raven.wrap(function (signal) {
for (const id in cluster.workers) {
killWorker(cluster.workers[id], signal);
}
fs.unlinkSync(SOCKET_PATH);
process.exit();
};
});

let hupAction = null;
const hup = Raven.wrap(function () {
@@ -105,7 +105,7 @@ if (cluster.isMaster) {
initialTimeout = 2000;
}

function killNext() {
const killNext = Raven.wrap(function () {
if (!oldWorkers) {
oldWorkers = Object.values(cluster.workers);
}
@@ -121,7 +121,7 @@ if (cluster.isMaster) {
} else {
hupAction = null;
}
}
});

hupAction = setTimeout(killNext, initialTimeout);
});
@@ -25,7 +25,7 @@ const connectionListener = Raven.wrap(function (socket) {
recvBytes = 0;
}

function receiveData(data) {
const receiveData = Raven.wrap(function (data) {
if (!recvBuffer) {
expectedBytes = data.readUInt32LE(0);
recvBuffer = allocBuffer(expectedBytes);
@@ -73,7 +73,7 @@ const connectionListener = Raven.wrap(function (socket) {
receiveData(overflow);
}
}
}
});

socket.on('close', clearRecv);
socket.on('error', clearRecv);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.