Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hacky TT timeline code #622

Merged
merged 5 commits into from Mar 28, 2018
Merged

Conversation

@mwiencek
Copy link
Member

@mwiencek mwiencek commented Mar 1, 2018

We were using some very wacky TT to generate JavaScript code for the client. This replaces all of that with actual JavaScript. The dynamic bits are fetched via ajax and constructed on the client.

@mwiencek mwiencek force-pushed the nix-timeline-hacks branch 3 times, most recently from d2be552 to e08f42b Mar 3, 2018
@mwiencek mwiencek requested review from samj1912 and yvanzo Mar 16, 2018
Copy link
Contributor

@yvanzo yvanzo left a comment

MusicBrainz events are not displayed anymore with FF (no log).

Loading

@mwiencek
Copy link
Member Author

@mwiencek mwiencek commented Mar 19, 2018

@yvanzo which version of FF? They are displayed for me in 52.7.2 ESR and 60.0b4. 🤔

Loading

yvanzo
yvanzo approved these changes Mar 28, 2018
yvanzo
yvanzo approved these changes Mar 28, 2018
Copy link
Contributor

@yvanzo yvanzo left a comment

That was not browser-specific. It did not work with hand-crafted test data. It works fine with current statistics.

Loading

mwiencek added 5 commits Mar 28, 2018
Return JSON directly and process it on the client to avoid unnecessary
work on the server.
Removes a point where data had to be passed from the Perl to the JS.
Allows us to remove an inline script tag with hacky TT code generation.
@mwiencek mwiencek force-pushed the nix-timeline-hacks branch from e08f42b to fe0867a Mar 28, 2018
@mwiencek mwiencek merged commit 9e815be into metabrainz:master Mar 28, 2018
1 check passed
Loading
@mwiencek mwiencek deleted the nix-timeline-hacks branch Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants