Convert entity sidebars to React #623
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The basic idea was that CDStubTOC modeled cdtoc_raw, and CDStub modeled release_raw. But there's no clear reason why these are separate models, since the tables have a 1:1 mapping (I'm not actually sure why they're separate tables). You can't submit a CD stub without a disc ID. So these models only serve to make the code confusing as to when you should expect which entity. For example, the CDStub entity class previously had discid and track_count properties as shortcuts for the indexed search, which didn't construct a full CDStubTOC in `schema_fixup`. These shortcuts made it unclear when, for example, $cdstubtoc->discid was defined as opposed to $cdstubtoc->cdstub->discid, or if $cdstubtoc->cdstub could always be expected to be loaded.
The component uses different (and probably harder to translate) strings than the expiration_time TT macro, and wraps the result in bracketed, which the macro didn't do. This commit also renames the component to ExpirationTime to match the TT macro, which makes more sense.
For hydrated components that take an entity prop, we were serializing the entire entity (potentially including a giant list of relationships, mediums, etc.) even though we only needed a few bits of data from it (such as the entity type and gid).
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.