Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions in generate.py, Abort on erros in generate.py #197

Merged
merged 3 commits into from Jan 1, 2019

Conversation

@mineo
Copy link
Member

mineo commented Jan 1, 2019

The commit messages have more details.

mineo added 3 commits Jan 1, 2019
The master branch doesn't even exist anymore.
call() just ignored any and all errors from the subprocesses.
check_call() raises an exception at the point where the error happens.
@mineo mineo force-pushed the mineo:generate-versions branch from ca4cce5 to f777a2a Jan 1, 2019
@phw
phw approved these changes Jan 1, 2019
@mineo mineo merged commit 9389d4d into metabrainz:2.0 Jan 1, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mineo mineo deleted the mineo:generate-versions branch Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.