Fixes for "Generate M3U playlist" #245 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
approved these changes
Mar 10, 2022
plugins/playlist/playlist.py
Outdated
| b_filename, b_selected_format = QtWidgets.QFileDialog.getSaveFileName( | ||
| None, "Save new playlist", | ||
| os.path.join(current_directory, default_filename), | ||
| "Playlist (*.m3u8 *.m3u)" | ||
| ) | ||
| if b_filename: | ||
| filename = string_(b_filename) | ||
| filename = str(b_filename) |
There was a problem hiding this comment.
Not sure if that str conversion is actually needed anymore here. Is it?
phw
requested changes
Apr 7, 2022
There was a problem hiding this comment.
@xjiro Can you please bump the plugin version to 1.2? That's needed before this PR can be
Also about your change replacing string_ with str, I think this str call is not needed at all there. This function was used to convert QByteArray or bytes to a string. But looking at other calls to e.g. QFileDialog.getSaveFileName in the Picard code this conversion no longer is necessary here.
… files, already documented as intended behavior. remove deprecated string_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
The default playlist location also works for multiple album selections.