Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin tangoinfo #56

Merged
merged 1 commit into from Jan 12, 2017
Merged

Add plugin tangoinfo #56

merged 1 commit into from Jan 12, 2017

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Aug 5, 2016

Rebasing on top of metabrainz:master made the old PR go away. As far as I can see, there were no issues left with the code, but I found a few myself.

The code is re-formatted to 80 characters wide and I caught an error where the album would not finalize loading when a certain condition was met.

I've thrown a lot of my albums of my collection at it and have not gotten Picard to lock up or write erroneous tags.

If anyone wants to test this on Windows or Mac, I have uploaded an album to test with here(@Sophist-UK your cousin might have this already). Let me know when you have downloaded it so I can take it down again and not get sued.
It is this album on tango.info and this release on MB.

You should notice year, genre and vocalist tags appearing when loading this into Picard.
MusicBrainz and tango.info disagree on this one(MB can only regnize a few tracks), but the plugin will figure out the correct mapping regardless.

@zas zas added the new plugin label Jan 12, 2017
@zas zas merged commit 9d91adc into metabrainz:master Jan 12, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants