Add plugin tangoinfo#56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing on top of metabrainz:master made the old PR go away. As far as I can see, there were no issues left with the code, but I found a few myself.
The code is re-formatted to 80 characters wide and I caught an error where the album would not finalize loading when a certain condition was met.
I've thrown a lot of my albums of my collection at it and have not gotten Picard to lock up or write erroneous tags.
If anyone wants to test this on Windows or Mac, I have uploaded an album to test with here(@Sophist-UK your cousin might have this already). Let me know when you have downloaded it so I can take it down again and not get sued.
It is this album on tango.info and this release on MB.
You should notice
year,genreandvocalisttags appearing when loading this into Picard.MusicBrainz and tango.info disagree on this one(MB can only regnize a few tracks), but the plugin will figure out the correct mapping regardless.