Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install/build instructions for Windows #175

Merged
merged 6 commits into from Dec 4, 2013

Conversation

Projects
None yet
3 participants
@JonnyJD
Copy link
Contributor

commented Nov 1, 2013

This was recently done by somebody and that is the information
that was missing.

The whole chat with snartal trying to build picard on Windows is here:
http://chatlogs.musicbrainz.org/musicbrainz-devel/2013/2013-10/2013-10-31.html#T19-34-31-251538

JonnyJD added some commits Nov 1, 2013

@JonnyJD

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2013

Something about chromaprint is possibly also missing from INSTALL.txt.
It worked for snartal, but he installed that before when using the picard setup probably.

INSTALL.txt Outdated
@@ -22,6 +22,15 @@ Before installing Picard, you need to have these libraries:
Due to slowdowns in reading the CD TOC, using libdiscid versions
0.3.0 - 0.4.1 is not recommended.

You also need these things to build Picard:

This comment has been minimized.

Copy link
@mineo

mineo Nov 1, 2013

Member

I don't think this line is really necessary.

This comment has been minimized.

Copy link
@JonnyJD

JonnyJD Nov 26, 2013

Author Contributor

Well, these things are no libraries like the things above.

This comment has been minimized.

Copy link
@JonnyJD

JonnyJD Nov 26, 2013

Author Contributor

Anyways, fixed. I changed that other line above and removed this one.

INSTALL.txt Outdated
You also need these things to build Picard:

* a compiler
Windows should work with VS2008, other compilers might need additional work.

This comment has been minimized.

Copy link
@mineo

mineo Nov 1, 2013

Member

I'm not sure what the compiler situation on windows is, but ideally we'd list one compiler which we know works and that's it, because I don't think anyone wants to really support building Picard on windows, as none of our developers seem to use it :)

This comment has been minimized.

Copy link
@JonnyJD

JonnyJD Nov 26, 2013

Author Contributor

I linked MSVC 2008 express now.

INSTALL.txt Outdated
Windows should work with VS2008, other compilers might need additional work.

* gettext installed
Search for "gettext Windows" for Windows binaries.

This comment has been minimized.

Copy link
@mineo

mineo Nov 1, 2013

Member

The same as above, we should link to one project which provides gettext for windows where we know that it works.

INSTALL.txt Outdated
@@ -59,3 +68,24 @@ the Source Tree". Afterward you can run the tests using setup.py:

Alternatively, use a test runner such as nose.


Note for Windows users

This comment has been minimized.

Copy link
@mineo

mineo Nov 1, 2013

Member

I'd prefer a shortened version of this paragraph along the lines of

On Windows, the directories containing the python and gettext executables need to be in your PATH environment variable.

after the dependencies list and then just a short note

On Windows, the command python setup.py install has to be run as a user with administrator privileges instead of sudo blabla.

after the sudo thing.

This comment has been minimized.

Copy link
@JonnyJD

JonnyJD Nov 26, 2013

Author Contributor

I moved the information from this section to the other sections now (and shortened it).

INSTALL.txt Outdated
On Windows the user starting the installation should have admin rights.

There is also a guide on getting Picard to build on Windows:
http://musicbrainz.org/doc/How_to_Build_Picard_for_Windows

This comment has been minimized.

Copy link
@mineo

mineo Nov 1, 2013

Member

It feels a bit weird to link to this guide because this is INSTALL.txt which is supposed to cover how to install Picard. Maybe we could incorporate the guide into this document - after all, the only additional requirements seem to be NSIS, py2exe and the short building the installer section?

This comment has been minimized.

Copy link
@JonnyJD

JonnyJD Nov 26, 2013

Author Contributor

Removed.

@JonnyJD

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2013

Yeah, I'll try to test a Windows build in a VM and see what is necessary and what not.

Then I'll update both the wiki and this PR.

@zas

This comment has been minimized.

Copy link
Collaborator

commented Nov 25, 2013

@JonnyJD : any update on this ?

@JonnyJD

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2013

Yes, working on this. Hopefully finished today. First step was fixing up a clean Windows VM and updating it. That updating part took the rest of the allotted time so I had to postpone the actual testing.
(installing VS2008 also took ages)

@JonnyJD

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2013

I'm still working on the wiki and have to test py2exe, but the install.txt here should be fine now.
I got Picard up and running with these steps (from a somewhat fresh Windows XP 32 bit).

@JonnyJD

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2013

FYI: http://musicbrainz.org/doc/How_to_Build_Picard_for_Windows is also up to date now and building the installer is tested with these instructions.

I also added chromaprint as an optional dependency in INSTALL.txt. This has nothing to do with Windows, but was missing anyways.

@zas

This comment has been minimized.

Copy link
Collaborator

commented Dec 2, 2013

I think we can merge this now.

zas added a commit that referenced this pull request Dec 4, 2013

Merge pull request #175 from JonnyJD/make_depends
Fix install/build instructions for Windows

@zas zas merged commit fb06f7b into metabrainz:master Dec 4, 2013

@JonnyJD JonnyJD deleted the JonnyJD:make_depends branch Dec 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.